Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify VMware compute profile test #14202

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Modify VMware compute profile test #14202

merged 1 commit into from
Mar 22, 2024

Conversation

shubhamsg199
Copy link
Contributor

Modifying the VMware compute profile test by making it end-to-end and removing redundant test as a part of Component Audit

@shubhamsg199 shubhamsg199 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Feb 28, 2024
@shubhamsg199 shubhamsg199 self-assigned this Feb 28, 2024
@shubhamsg199 shubhamsg199 requested a review from a team as a code owner February 28, 2024 08:16
@shubhamsg199 shubhamsg199 force-pushed the vmware_compute_profile branch 2 times, most recently from d4f85f3 to 6154f42 Compare February 28, 2024 08:30
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_vmware.py -k test_positive_vmware_custom_profile_end_to_end

1 similar comment
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_vmware.py -k test_positive_vmware_custom_profile_end_to_end

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5870
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_computeresource_vmware.py -k test_positive_vmware_custom_profile_end_to_end --external-logging
Test Result : ========== 2 failed, 10 deselected, 33 warnings in 1486.24s (0:24:46) ==========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 28, 2024
ogajduse
ogajduse approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK code-wise. Please check the PRT failures, it seems that airgun is not able to target the element.

Message: invalid selector: Unable to locate an element with the xpath expression ./li[not(contains(@style, 'display: none'))][normalize-space(.)='('Default',)'] because of the following error:
SyntaxError: Failed to execute 'evaluate' on 'Document': The string './li[not(contains(@style, 'display: none'))][normalize-space(.)='('Default',)']' is not a valid XPath expression.

tests/foreman/ui/test_computeresource_vmware.py Outdated Show resolved Hide resolved
@shubhamsg199 shubhamsg199 force-pushed the vmware_compute_profile branch 2 times, most recently from a8986cd to c6a9616 Compare February 28, 2024 12:53
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_vmware.py -k test_positive_vmware_custom_profile_end_to_end

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5881
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_computeresource_vmware.py -k test_positive_vmware_custom_profile_end_to_end --external-logging
Test Result : ========== 2 failed, 10 deselected, 37 warnings in 3400.25s (0:56:40) ==========

@shubhamsg199 shubhamsg199 force-pushed the vmware_compute_profile branch 3 times, most recently from 429c14c to a7c90e4 Compare February 28, 2024 17:47
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Feb 28, 2024
@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Feb 29, 2024
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Feb 29, 2024
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Feb 29, 2024
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Mar 4, 2024
@shubhamsg199 shubhamsg199 force-pushed the vmware_compute_profile branch from a7c90e4 to a89e2b9 Compare March 5, 2024 08:16
@shubhamsg199 shubhamsg199 force-pushed the vmware_compute_profile branch from c6b0df1 to f2505b0 Compare March 13, 2024 06:46
@shubhamsg199 shubhamsg199 requested a review from a team as a code owner March 13, 2024 06:46
@shubhamsg199 shubhamsg199 force-pushed the vmware_compute_profile branch 3 times, most recently from 11689d0 to 1ceca06 Compare March 13, 2024 13:58
@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_vmware.py -k test_positive_vmware_custom_profile_end_to_end

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6097
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_computeresource_vmware.py -k test_positive_vmware_custom_profile_end_to_end --external-logging
Test Result : ========== 2 failed, 10 deselected, 44 warnings in 9092.56s (2:31:32) ==========

@Satellite-QE Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Mar 18, 2024
@shubhamsg199
Modify VMware compute profile test
61892fa 
Signed-off-by: Shubham Ganar <[email protected]>
Signed-off-by: Shubham Ganar <[email protected]>
@shubhamsg199 shubhamsg199 force-pushed the vmware_compute_profile branch from 1ceca06 to 61892fa Compare March 22, 2024 07:25
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Mar 22, 2024
@Satellite-QE Satellite-QE removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 22, 2024
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_vmware.py -k test_positive_vmware_custom_profile_end_to_end

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6161
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_computeresource_vmware.py -k test_positive_vmware_custom_profile_end_to_end --external-logging
Test Result : ===== 1 failed, 1 passed, 10 deselected, 41 warnings in 8451.84s (2:20:51) =====

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 22, 2024
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_vmware.py -k test_positive_vmware_custom_profile_end_to_end

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6164
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_computeresource_vmware.py -k test_positive_vmware_custom_profile_end_to_end --external-logging
Test Result : ========== 2 passed, 10 deselected, 46 warnings in 8713.82s (2:25:13) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Mar 22, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit 34db8df into SatelliteQE:master Mar 22, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 22, 2024
@shubhamsg199 @web-flow
Modify VMware compute profile test (#14202)
7ddd9f5 
Signed-off-by: Shubham Ganar <[email protected]>
Signed-off-by: Shubham Ganar <[email protected]>
(cherry picked from commit 34db8df)
github-actions bot pushed a commit that referenced this pull request Mar 22, 2024
@shubhamsg199 @web-flow
Modify VMware compute profile test (#14202)
a9e2168 
Signed-off-by: Shubham Ganar <[email protected]>
Signed-off-by: Shubham Ganar <[email protected]>
(cherry picked from commit 34db8df)
This was referenced Mar 22, 2024
Merged
Merged
Gauravtalreja1 pushed a commit that referenced this pull request Mar 22, 2024
@Satellite-QE @shubhamsg199
[6.15.z] Modify VMware compute profile test (#14495)
8ccf0ee 
Modify VMware compute profile test (#14202)

Signed-off-by: Shubham Ganar <[email protected]>
Signed-off-by: Shubham Ganar <[email protected]>
(cherry picked from commit 34db8df)

Co-authored-by: Shubham Ganar <[email protected]>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@shubhamsg199 @shweta83
Modify VMware compute profile test (SatelliteQE#14202)
159662f 
Signed-off-by: Shubham Ganar <[email protected]>
Signed-off-by: Shubham Ganar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameerpathan111 jameerpathan111 jameerpathan111 left review comments

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@ogajduse ogajduse ogajduse approved these changes

@lhellebr lhellebr lhellebr approved these changes

Assignees

@shubhamsg199 shubhamsg199

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shubhamsg199 @Satellite-QE @Gauravtalreja1 @lhellebr @ogajduse @jameerpathan111